Skip to content

Vb/fix dd method dashboard #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Vb/fix dd method dashboard #1880

merged 3 commits into from
Oct 28, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Oct 23, 2024

Description

New DD SDK Method dashboard is not capturing api calls via Pagination correctly. Instead of capturing actual parent sdk call, it reports it just as Client.execute.

As an example that we have addressed, dataset.data_rows now appears correctly for this test run

Screenshot 2024-10-25 at 11 47 17 AM

This PR will address the issue specific to pagination
Other code places that report just as Client execute will be addressed later in this story

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky force-pushed the VB/fix-dd-method-dashboard branch from 0318f3b to 14ebbc7 Compare October 23, 2024 22:30
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-clients October 23, 2024 22:31 — with GitHub Actions Inactive
@vbrodsky vbrodsky marked this pull request as ready for review October 25, 2024 18:37
@vbrodsky vbrodsky requested a review from a team as a code owner October 25, 2024 18:37
@vbrodsky vbrodsky merged commit 0a3e3b1 into develop Oct 28, 2024
20 of 26 checks passed
@vbrodsky vbrodsky deleted the VB/fix-dd-method-dashboard branch October 28, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants